feat(eval): support session trace filters and log group prefixes - #2345
Merged
Merged
Conversation
agentcore-devx-automation
Bot
added
agentcore-harness-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
![agentcore-devx-automation[bot]](https://avatars.githubusercontent.com/u/2232217?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, well-scoped change: SDK bump to pick up sessionTraceIds, help-text update, and a test covering the raw pass-through path.
- Verified
SessionTraceIds/CloudWatchFilterConfig.sessionTraceIdsexist in@aws-sdk/client-bedrock-agentcore@3.1136.0, so the^3.1135.0bump is sufficient. - The test in
src/core/batchEvaluation.test.tsxmocks at the AWS SDK client boundary (send), which is the right layer — not over-mocked. - No new user-facing commands are introduced, so no additional telemetry instrumentation is warranted.
One minor thing to double-check (not a blocker): the help text in src/handlers/eval/sessionSource.tsx states traceIds accepts "up to 100 trace IDs". The SDK typings don't encode that limit; worth confirming against the public API docs before this misleads users if the real cap differs. Fine to address in a follow-up.
agentcore-devx-automation
Bot
removed
the
agentcore-harness-reviewing
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2345 +/- ##
=========================================
Coverage 97.26% 97.26%
=========================================
Files 610 610
Lines 40590 40605 +15
=========================================
+ Hits 39480 39495 +15
Misses 1110 1110 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jariy17
force-pushed
the
feat/batch-evaluation-session-trace-filters
branch
from
September 18, 2026 23:14
d5ac908 to
576581f
Compare
jariy17
changed the title
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
jariy17
changed the title
nborges-aws
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CloudWatchFilterConfig.sessionTraceIdssessionTraceIdsandlogGroupNamePrefixesin the existing batch-evaluation--data-source-confighelpStartBatchEvaluationCommandunchangedlogGroupNamePrefixesas well as exact log group namesTesting
bun test src/handlers/eval/batch-evaluation/batch-evaluation.fixture.test.tsx src/handlers/eval/online-eval/online-eval.test.tsxbun test src/core/onlineEvalExecutionRole.test.ts src/handlers/eval/batch-evaluation/batch-evaluation.test.tsx src/handlers/eval/online-eval/online-eval.screen.test.tsxbun run typecheckbunx oxlint src/core/eval.tsx src/core/onlineEvalExecutionRole.tsx src/handlers/eval/sessionSource.tsx src/handlers/eval/batch-evaluation/batch-evaluation.fixture.test.tsx src/handlers/eval/online-eval/online-eval.test.tsxgit diff --check